hidden widgets do not get a label anymore

6 years ago · fce6d29bdf
parent c37f3aec8d
commit fce6d29bdf
2 changed files with 4 additions and 3 deletions
--- a/src/formulare/core.clj
+++ b/src/formulare/core.clj
@ -118,7 +118,8 @@
    (list
     (when (and validate? (not (spec/valid? spec req-value)))
       (spec-to-errmsg label spec req-value))
-     (hform/label id label)
+     (when-not (= :hidden widget)
+       (hform/label id label))
     (renderer id def (if validate? req-value value)))))

 (defn form-hash [def values]
--- a/test/formulare/core_test.clj
+++ b/test/formulare/core_test.clj
@ -190,7 +190,7 @@
    (let [def {:fields {:foo-id {:label "foo-label"
                                 :widget :hidden}}}]
      (is (= (list nil
-                   [:label {:for "foo-id"} "foo-label"]
+                   nil
                   [:input {:id "foo-id"
                            :type "hidden"
                            :name "foo-id"
@ -202,7 +202,7 @@
    (let [def {:fields {:foo-id {:label "foo-label"
                                 :widget :hidden}}}]
      (is (= (list nil
-                   [:label {:for "foo-id"} "foo-label"]
+                   nil
                   [:input {:id "foo-id"
                            :type "hidden"
                            :name "foo-id"